Fix Connections regressions from #102265 by Krishna2323 · Pull Request #104402 · Expensify/App

Krishna2323 · 2026-10-19T21:20:45Z

Explanation of Change

Fixes the regressions reported after #102265. The launch (beta removal, page deletions, link updates and the onboarding text) is in #, on top of this one, so it can be reverted without these fixes.

Manage settings on More features now opens /connections instead of /accounting.
The Suggest an integration footer link now opens Concierge instead of #admins.
Disconnect now closes the panel first and removes the connection after the close animation, so the Not Found page no longer flashes. Covers accounting, Uber and HR/Recruiting.
Import / Advanced / Export pages now go Back to the integration's Connections panel, even after a refresh.
Connecting an integration on a workspace that is still being created no longer turns the Connections page behind the RHP into a loader.
On Collect workspaces, opening Connections now loads the accounting data, so connecting an integration doesn't replace the page with a loader.

Fixed Issues

$ #104013
$ #104032
$ #104319
$ #104320
$ #104029
$ #104321
PROPOSAL: N/A, follow-up to #102265

Tests

Precondition: enable the unifiedConnections beta.

Connect any accounting integration. Go to More features, turn off Categories and click Manage settings. Verify the URL ends with /connections.
On Connections, scroll down and click the footer link. Verify Concierge opens.
Open a connected accounting integration and click the 3-dot menu > Disconnect > Disconnect. Verify the panel closes without showing the Not Found page. Repeat for Uber, and for an HR or Recruiting provider.
Open a connected integration (for example Sage Intacct) > Import. Refresh the page and click Back. Verify the integration's panel opens instead of the RHP closing. Repeat with Advanced.
Create a new workspace and quickly go to its Connections page. Click any accounting integration (for example NetSuite). Verify the page behind the RHP does not turn into a loading spinner.
Have workspace A with NetSuite still setting up. Create a new workspace B, open Connections, click Rillet. Verify the Rillet connect flow opens, not More features. Go back to Connections and verify it isn't loading.
On a Collect workspace with no integration connected, open Connections and connect any accounting integration. Verify the page doesn't turn into a loader.

Verify that no errors appear in the JS console

Offline tests

Precondition: enable the unifiedConnections beta.

Go offline and repeat test 3. Verify the panel closes and the integration shows as disconnected on Connections.
Go back online. Verify the disconnect syncs.

QA Steps

Same as tests, with the unifiedConnections beta enabled.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

test_1.mp4

…oncierge, disconnect flash, and Back after refresh on settings pages Signed-off-by: krishna2323 <[email protected]>

codecov · 2026-10-19T21:27:06Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/Policy/Policy.ts	`72.76% <100.00%> (+0.37%)`	⬆️
...ages/workspace/WorkspaceMoreFeaturesPage/index.tsx	`64.28% <ø> (ø)`
...s/workspace/accounting/AccountingContext/index.tsx	`95.77% <100.00%> (+0.25%)`	⬆️
...sinessCentral/import/BusinessCentralImportPage.tsx	`85.52% <100.00%> (+0.39%)`	⬆️
...ace/accounting/qbo/import/QuickbooksImportPage.tsx	`82.60% <100.00%> (+0.79%)`	⬆️
...space/connections/ConnectionsMergeProviderCard.tsx	`0.00% <ø> (ø)`
...workspace/connections/WorkspaceConnectionsPage.tsx	`97.34% <100.00%> (+4.12%)`	⬆️
...orkspace/connections/ConnectionsAccountingPage.tsx	`97.14% <0.00%> (ø)`
...workspace/connections/ConnectionsMergePageBase.tsx	`80.00% <0.00%> (ø)`
...ace/connections/ConnectionsReceiptPartnersPage.tsx	`83.33% <0.00%> (ø)`
... and 24 more
... and 13 files with indirect coverage changes

Krishna2323 · 2026-10-19T21:52:15Z

@JmillsExpensify @trjExpensify @lakchote Two questions before I open it for review:

Can we turn on the new Connections page for everyone in this PR?
- If yes, everyone will see "Connections" instead of the separate Accounting, HR, Recruiting, Receipt partners and MCP pages. Old links to those pages will still open Connections.
Onboarding task text (Onboarding - Onboarding task shows "Click Accounting" when there is no Accounting tab #104011)
- When someone finishes onboarding and picks an accounting tool, we post a task in #admins with steps like "1. Click Workspaces, 2. Select your workspace, 3. Click Accounting". With the new page there is no "Accounting" tab. It's called "Connections".
- The task is written once and doesn't update later. The link inside it already opens the right page. Only the step text is wrong.

Which do you prefer?

If we turn the new page on for everyone (question 1), change the step to "Click Connections" for everyone in this PR. This is the simplest option.
Show "Click Connections" only to people who have the new page. Downside: someone who gets the new page after onboarding will still see "Accounting".
Use wording that works for both, like "Click Accounting (or Connections)".

…an integration turns Connections on Signed-off-by: krishna2323 <[email protected]>

trjExpensify · 2026-10-19T21:59:52Z

Can we turn on the new Connections page for everyone in this PR?

If yes, everyone will see "Connections" instead of the separate Accounting, HR, Recruiting, Receipt partners and MCP pages. Old links to those pages will still open Connections.

I'm fine with this, so long as we go through staging regression testing first. What we want to avoid is deploying it so customers see the consolidated page and then reverting it.

If we turn the new page on for everyone (question 1), change the step to "Click Connections" for everyone in this PR. This is the simplest option.

Yeah, let's do this. We could have the link open on the Accounting tab in Connections as well btw.

Signed-off-by: krishna2323 <[email protected]>

melvin-bot · 2026-10-19T22:32:19Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

Krishna2323 · 2026-10-19T22:40:07Z

@MelvinBot review

MelvinBot · 2026-10-19T22:56:39Z

Review

The PR looks solid overall. I found one real regression to fix before merge, and a few small issues. The four fixes in the description all check out in the code.

Should fix

Admins can no longer turn MCP off. This PR removes the MCP toggle from More features for everyone. Nothing in the UI calls enablePolicyMCP with false any more. Two problems follow:
- MCP is on by default (features.ts:95-96). So no admin can now block AI-assistant access to a workspace.
- If a workspace already has MCP off, only the Claude, Cursor and ChatGPT cards turn it back on. The generic MCP card just opens the guide (useMCPConnectionListings.ts:51-58). An admin who follows that guide for another client can't turn MCP on.
Please confirm this is intended, or add an on/off control.

Minor

Some links still open the "All" tab, not the integration's settings. These links used to open the HR or Recruiting page. Now they open the Connections grid, and the user has to click again:
- WorkspaceMembersPage.tsx:504
- WorkflowUtils.ts:59 and :65
You could point them at WORKSPACE_CONNECTIONS_HR / _RECRUITING, or use the new tab param.
Card reconciliation Back always opens the accounting panel. CardReconciliationPage.tsx:150 used to pop the stack. If you open this page from the Expensify Card settlement-account link, Back now loses where you came from.
The "nothing to fetch" check may be wrong. Policy.ts:5163-5167 treats empty policy.connections as "no connections". For a workspace whose connections were never loaded, empty can mean "not loaded". Then an existing connection wouldn't load after you turn Connections on. This only matters if the backend allows a connection while Connections is off. I didn't confirm that.
About 15 callers still navigate to ROUTES.POLICY_ACCOUNTING. Examples are RulesRequireFieldsPage and ImportedFromAccountingSoftware. They work, but they open Connections at /accounting without the Accounting tab. That's optional cleanup.
The PR description is out of date. The last commit removes the beta for everyone. But the description still says "behind the unifiedConnections beta", and test step 5 still tests "without the beta". Please update it, including the onboarding "Click Connections" change.

What I checked

Deleted code: nothing in src/ or tests/ still references the deleted pages, hooks, beta constant or translation keys.
Old routes: /accounting, /hr, /recruiting, /mcp and /receipt-partners now render WorkspaceConnectionsPage.
Ported behavior: auto-start from newConnectionName, the QBO token-expiry hint, the Uber invite flow and switching integrations all moved over.
Disconnect: all three panels use Navigation.goBack(..., {afterTransition}). That runs the removal once, outside the component, and still runs if the panel unmounts.
Back navigation: this covers every integration's Import/Advanced/Export page, through a fixed route or useDynamicBackPath.
Not run: I didn't run typecheck or test the app. I checked locale cleanup with grep only.

view run

…liation Back on the stack, and only skip the connections fetch for a workspace still being created Signed-off-by: krishna2323 <[email protected]>

…anel where an integration is connected, the Accounting tab otherwise Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2026-10-20T00:02:10Z

@MelvinBot review

chatgpt-codex-connector · 2026-10-20T00:05:58Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-20T00:25:32.416492Z	`b9ab7dd`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

melvin-bot · 2026-10-20T00:05:59Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-10-20T00:11:10Z

Follow-up review

I reviewed the two new commits. They fix four of my earlier points and introduce no new bugs. Two points are still open.

Fixed

HR and Recruiting links now open their panels.
Card reconciliation Back uses the navigation stack again.
The fetch is now skipped only for a workspace that is still being created (Policy.ts:5163-5168).
Links to the old Accounting page now point at Connections. Nothing in src/ still uses POLICY_ACCOUNTING, WORKSPACE_ACCOUNTING, WORKSPACE_HR or WORKSPACE_RECRUITING routes. Each link that opens the accounting panel is only reachable while an integration is connected, so none of them lands on Not Found.

Still open

Admins still can't turn MCP off. Nothing in the UI calls enablePolicyMCP with false, and MCP is on by default (features.ts:95-96). Please confirm this is intended, or add an on/off control.
The PR description is still out of date. It says the changes are behind the beta, and test step 5 tests "without the beta". Item 4 also says Card reconciliation goes Back to the panel after a refresh, which the latest commit no longer does.

Optional: four callers now pass four undefined arguments to reach tab in WORKSPACE_CONNECTIONS.getRoute. One example is ReportActionsUtils.ts:5362. An options object would be easier to read.

I didn't run typecheck or test the app.

view run

JmillsExpensify · 2026-10-20T07:20:28Z

My quick comments:

Yes, let's turn it on for everyone (agree with Tom that we need to be on top of staging regressions).
Fine updating from Accounting to Connections in onboarding but that's polish. It doesn't need to happen before this gets released.

Krishna2323 · 2026-10-22T20:31:21Z

@situchan Updated the description and Fixed Issues.

situchan · 2026-10-22T20:32:42Z

Please merge main

…sions

situchan · 2026-10-22T20:59:39Z

#104320 is still reproducible. after clicking on accounting, app still opens More features

Screen.Recording.2026-10-22.at.9.57.38.PM.mov

situchan · 2026-10-22T22:07:26Z

Looks good except #104402 (comment).
And #104011 should be removed from Fixed Issues

…s page doesn't send the user to More features before the change lands Signed-off-by: krishna2323 <[email protected]>

…nections-regressions # Conflicts: # src/pages/workspace/accounting/businessCentral/export/BusinessCentralExportPage.tsx

Krishna2323 · 2026-10-23T14:48:22Z

#104320 is still reproducible. after clicking on accounting, app still opens More features

@situchan could you please test again? It should be fixed now.

Krishna2323 · 2026-10-23T14:55:08Z

Failing unit tests isn't related to this PR.

situchan · 2026-10-23T15:58:10Z

#104320 pass ✅

104320.mov

lakchote

Thanks @Krishna2323! Waiting a frame before opening the setup flow fixes the More features redirect, and @situchan's retest passed. LGTM.

cc @Beamanator @mollfpr

Beamanator

Looking great to me!

github-actions · 2026-10-24T15:09:02Z

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-24T15:11:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-24T15:14:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104402 with the pinned Mobile-Expensify submodule.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c08c85f3-18b639c-4235a29ae86124505305ea6ab9796067a847befa/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c08c85f3-18b639c-6e721b38ab52f9ab9fca9106cebffa8966f8bd24/index.html

Web 🕸️
https://104402.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-26T20:57:38Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.21-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-26T21:04:06Z

No help site update is needed: every change in this PR fixes regressions on the Connections page, and that page is only visible behind the unifiedConnections beta (the beta removal ships in a separate launch PR).

view run

OSBotify · 2026-10-27T00:06:29Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.5.23-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-27T00:08:48Z

No help site update is needed: every change in this PR fixes regressions on the Connections page, which is still only visible behind the unifiedConnections beta on main (the beta removal ships in a separate launch PR).

view run

OSBotify · 2026-10-27T22:06:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Fix Connections regressions: Manage settings route, suggest link to C…

da5fdf3

…oncierge, disconnect flash, and Back after refresh on settings pages Signed-off-by: krishna2323 <[email protected]>

melvin-bot Bot assigned Krishna2323 Oct 19, 2026

Keep the Connections page from turning into a loader when connecting …

3847d51

…an integration turns Connections on Signed-off-by: krishna2323 <[email protected]>

remove the unifiedConnections beta and the pages it replaced

49a85b4

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 added 2 commits October 20, 2026 05:10

Open the HR and Recruiting panels from their links, keep Card reconci…

0b1c2bd

…liation Back on the stack, and only skip the connections fetch for a workspace still being created Signed-off-by: krishna2323 <[email protected]>

Point the remaining Accounting links at Connections: the accounting p…

b9ab7dd

…anel where an integration is connected, the Accounting tab otherwise Signed-off-by: krishna2323 <[email protected]>

Krishna2323 marked this pull request as ready for review October 20, 2026 00:05

Krishna2323 requested review from a team as code owners October 20, 2026 00:05

melvin-bot Bot requested a review from situchan October 20, 2026 00:05

melvin-bot Bot removed the request for review from a team October 20, 2026 00:05

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 20, 2026 00:05

Merge branch 'Expensify:main' into krishna2323/fix/connections-regres…

a7f15fe

…sions

Open the accounting setup a frame after turning Connections on, so it…

576f5ea

…s page doesn't send the user to More features before the change lands Signed-off-by: krishna2323 <[email protected]>

Krishna2323 dismissed lakchote’s stale review via 576f5ea October 23, 2026 14:46

Merge remote-tracking branch 'upstream/main' into krishna2323/fix/con…

b0cc973

…nections-regressions # Conflicts: # src/pages/workspace/accounting/businessCentral/export/BusinessCentralExportPage.tsx

situchan approved these changes Oct 23, 2026

View reviewed changes

melvin-bot Bot requested review from Beamanator, lakchote and mollfpr October 23, 2026 15:58

lakchote approved these changes Oct 23, 2026

View reviewed changes

Beamanator approved these changes Oct 23, 2026

View reviewed changes

lakchote merged commit c08c85f into Expensify:main Oct 24, 2026
44 of 47 checks passed

OSBotify mentioned this pull request Oct 26, 2026

Deploy Checklist: New Expensify 2026-10-26 #105056

Closed

84 tasks done

Krishna2323 mentioned this pull request Oct 27, 2026

Launch unified Connections: remove the beta and the pages it replaced #105137

Open

54 tasks done

applause-bot Bot mentioned this pull request Oct 27, 2026

Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape #105148

Open

1 of 7 tasks

melvin-bot Bot mentioned this pull request Oct 27, 2026

[Due for payment 2026-11-03] Connections - Clicking on accounting opens More features when connection is establishing #104320

Open

2 of 7 tasks

Conversation

Krishna2323 commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Oct 19, 2026

Which do you prefer?

Uh oh!

trjExpensify commented Oct 19, 2026

Uh oh!

melvin-bot Bot commented Oct 19, 2026

Uh oh!

Krishna2323 commented Oct 19, 2026

Uh oh!

MelvinBot commented Oct 19, 2026

Review

Uh oh!

Krishna2323 commented Oct 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

MelvinBot commented Oct 20, 2026

Follow-up review

Uh oh!

JmillsExpensify commented Oct 20, 2026

Uh oh!

Krishna2323 commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 22, 2026

Uh oh!

situchan commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 22, 2026

Uh oh!

Krishna2323 commented Oct 23, 2026

Uh oh!

Krishna2323 commented Oct 23, 2026

Uh oh!

situchan commented Oct 23, 2026

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 24, 2026

Uh oh!

OSBotify commented Oct 24, 2026

Uh oh!

github-actions Bot commented Oct 24, 2026

Uh oh!

OSBotify commented Oct 26, 2026

Uh oh!

MelvinBot commented Oct 26, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

MelvinBot commented Oct 27, 2026

Uh oh!

OSBotify commented Oct 27, 2026

Uh oh!

Reviewers

Krishna2323 commented Oct 19, 2026 •

edited

Loading

codecov Bot commented Oct 19, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading

Krishna2323 commented Oct 22, 2026 •

edited

Loading

situchan commented Oct 22, 2026 •

edited

Loading